Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Input] NbInput - debounce #673

Open
1 of 2 tasks
Tibing opened this issue Aug 23, 2018 · 7 comments
Open
1 of 2 tasks

[Input] NbInput - debounce #673

Tibing opened this issue Aug 23, 2018 · 7 comments

Comments

@Tibing
Copy link
Member

@Tibing Tibing commented Aug 23, 2018

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request

I think we have to add debounce property to the nbInput directive.

@Prefix1802
Copy link
Contributor

@Prefix1802 Prefix1802 commented Aug 23, 2018

@Tibing

Could you elaborate why?

@Tibing
Copy link
Member Author

@Tibing Tibing commented Aug 23, 2018

Hi @Prefix1802, I mean, this is a really common use case when you need to add debouncing on your inputs: search, filter, maybe error handling, whatever. And if input itself can't debounce its events you have to write rxjs every time you need debouncing.
Anyway, it's just the proposal and has to be discussed.

@Prefix1802
Copy link
Contributor

@Prefix1802 Prefix1802 commented Aug 23, 2018

@Tibing

I understand now. You said property ;), so we can use it as a parameter.

+1

@fabioloreggian
Copy link

@fabioloreggian fabioloreggian commented Oct 9, 2018

How would you like to use the debounce property?

My thought would be a @Input() debounce: number;
where this would be the debounce rate in milliseconds?

I am trying my hand at contributing to awesome angular projects and I really fancy nebular and ngx-admin.

@nnixaa nnixaa changed the title NbInput - debounce [Input] NbInput - debounce Jun 3, 2019
@sulha199
Copy link

@sulha199 sulha199 commented Jul 1, 2019

How would you like to use the debounce property?

My thought would be a @Input() debounce: number;
where this would be the debounce rate in milliseconds?

I am trying my hand at contributing to awesome angular projects and I really fancy nebular and ngx-admin.

Agree, and then use the debounce value to pipe the output such as on value change event.

@Tibing ,

Is this issue still open? I am interested to work on it?

@yassernasc
Copy link

@yassernasc yassernasc commented Oct 16, 2019

and then provide a rxjs stream by @Output?
but how we can access the input changes inside the nbInput directive?

@sethi-ishmeet
Copy link

@sethi-ishmeet sethi-ishmeet commented Mar 24, 2020

@Prefix1802 @nnixaa @Tibing

I would like to work on this feature request. I am just starting off to contributing on open source projects on GitHub.

My Proposal:

  • I would like to create a property @Input() debounce: number;.
  • And after the debounced time, would like to emit the keyup event through an output property like:
  @Output()
  debouncedKeyup = new EventEmitter();

Please let me know if this is feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants