Skip to content

fix: debugMode should be inherited from parent when mounted#1469

Merged
spydon merged 2 commits intomainfrom
spydon.fix-debug-mode
Mar 19, 2022
Merged

fix: debugMode should be inherited from parent when mounted#1469
spydon merged 2 commits intomainfrom
spydon.fix-debug-mode

Conversation

@spydon
Copy link
Copy Markdown
Member

@spydon spydon commented Mar 19, 2022

Description

debugMode wasn't propagating properly from the parent component to it's descendants.
If you for example added a component a to a component b first, and then added b to c which had debugMode = true, a would not have debugMode = true. But if a was added to b after it was added to c, then a would have debugMode = true.

This also fixes the debugMode for HitboxShapes.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • No, this is not a breaking change.

Related Issues

Copy link
Copy Markdown
Contributor

@wolfenrain wolfenrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spydon spydon merged commit e894d20 into main Mar 19, 2022
@spydon spydon deleted the spydon.fix-debug-mode branch March 19, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants