fix: throw explicit error if no input was provided for redirect#4297
Closed
maguroid wants to merge 5 commits intoyarnpkg:masterfrom
Closed
fix: throw explicit error if no input was provided for redirect#4297maguroid wants to merge 5 commits intoyarnpkg:masterfrom
maguroid wants to merge 5 commits intoyarnpkg:masterfrom
Conversation
Author
|
I need to fix this code to be available on subshell case (e.g. (echo 'hello world') > test.text)... |
maguroid
changed the title
Author
|
@arcanis You may be busy. If so, then please tell me how I should ask someone to review. |
RDIL
requested changes
Sep 9, 2022
| }); | ||
| }); | ||
|
|
||
| describe(`>>`, () => { |
Comment on lines
+1
to
+2
| undecided: | ||
| - "@yarnpkg/shell" |
Member
There was a problem hiding this comment.
I think that this should probably be minor on shell and the CLI, declining the rest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
package script fail to "The "file" argument must be of type string. Received undefined" when script start with ">" symbol.
Fixes #3986
How did you fix it?
Checking if redirection have input. If no input was passed, throw error.
Checklist
I have read the Contributing Guide.
I have set the packages that need to be released for my changes to be effective.
I will check that all automated PR checks pass before the PR gets reviewed.