➜
This issue tracker will soon become read-only and move to GitHub.
For a smoother transition, remember to
log in and link your GitHub username to your profile.
For more information,
see this post about the migration.
Created on 2017-12-01 09:44 by asvetlov, last changed 2017-12-08 22:25 by asvetlov. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 4753 | merged | asvetlov, 2017-12-07 22:13 | |
| Messages (6) | |||
|---|---|---|---|
| msg307375 - (view) | Author: Andrew Svetlov (asvetlov) *  |
Date: 2017-12-01 09:44 | |
As discussed several times before we need to convert `@coroutine` / `yield from` to async/await. All existing functionality should keep working (like yielding from new style coroutine and `with (yield from lock)`. We could deprecate the later though. The change should be huge but there is no alternative, keeping `yield from` in stdlib looks uglier and uglier every year. Unittests should be changed as well (keeping several `yield from` for checking backward compatibility is Ok). Opinions? |
|||
| msg307392 - (view) | Author: Guido van Rossum (gvanrossum) * |
Date: 2017-12-01 16:38 | |
Yeah, I am in favor of this. How will we guarantee that clients using the old `@coroutine`/`yield from` idiom still work? We need to have separate tests for that. |
|||
| msg307393 - (view) | Author: Yury Selivanov (yselivanov) * |
Date: 2017-12-01 16:48 | |
> How will we guarantee that clients using the old `@coroutine`/`yield from` idiom still work? They are fully supported now, but we can add a few tests to ensure we won't break it. |
|||
| msg307394 - (view) | Author: Yury Selivanov (yselivanov) * |
Date: 2017-12-01 16:50 | |
Andrew, would it be OK if I make a PR? |
|||
| msg307403 - (view) | Author: Andrew Svetlov (asvetlov) * |
Date: 2017-12-01 19:15 | |
Yuri please do |
|||
| msg307872 - (view) | Author: Andrew Svetlov (asvetlov) * |
Date: 2017-12-08 22:23 | |
New changeset 5f841b553814969220b096a2b4f959b7f6fcbaf6 by Andrew Svetlov in branch 'master': bpo-32193: Convert asyncio to async/await usage (#4753) https://github.com/python/cpython/commit/5f841b553814969220b096a2b4f959b7f6fcbaf6 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2017-12-08 22:25:13 | asvetlov | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2017-12-08 22:23:52 | asvetlov | set | messages: + msg307872 |
| 2017-12-07 23:07:24 | vstinner | set | nosy:
- vstinner |
| 2017-12-07 22:13:20 | asvetlov | set | keywords:
+ patch stage: patch review pull_requests: + pull_request4656 |
| 2017-12-01 19:15:47 | asvetlov | set | messages: + msg307403 |
| 2017-12-01 17:54:59 | terry.reedy | set | nosy:
+ terry.reedy |
| 2017-12-01 16:50:47 | yselivanov | set | messages: + msg307394 |
| 2017-12-01 16:48:57 | yselivanov | set | messages: + msg307393 |
| 2017-12-01 16:38:31 | gvanrossum | set | messages: + msg307392 |
| 2017-12-01 09:45:09 | asvetlov | set | type: enhancement |
| 2017-12-01 09:44:48 | asvetlov | set | nosy:
+ gvanrossum, vstinner |
| 2017-12-01 09:44:32 | asvetlov | create | |