Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getDerivedState docs for createClass #1214

Open
gaearon opened this issue Oct 1, 2018 · 5 comments · May be fixed by #1217
Open

Add getDerivedState docs for createClass #1214

gaearon opened this issue Oct 1, 2018 · 5 comments · May be fixed by #1217
Labels
difficulty: beginner good first issue type: documentation

Comments

@gaearon
Copy link
Member

@gaearon gaearon commented Oct 1, 2018

See facebook/react#13754
@gaearon gaearon mentioned this issue Oct 1, 2018
Closed
@alejandronanez
Copy link
Member

@alejandronanez alejandronanez commented Oct 1, 2018

I’d like to work on this this week. Is there anything I should base my work on in order to update the docs?

@gaearon
Copy link
Member Author

@gaearon gaearon commented Oct 1, 2018

Sure.

Not sure what you’re asking. Can you clarify?

@alejandronanez
Copy link
Member

@alejandronanez alejandronanez commented Oct 1, 2018

Oh sorry I wasn't clear enough! I wanted to know what would be a good starting point for this issue.

I'll start digging into it right now and I'll ping you if I get stuck!

@alejandronanez alejandronanez linked a pull request that will close this issue Oct 1, 2018
Open
@LadyGaga1208

This comment was marked as spam.

Sign in to view
@Ankit27Agg
Copy link

@Ankit27Agg Ankit27Agg commented Jun 2, 2020 •
edited

you have written that you want to add getDerivedState docs.
can you tell me what do you mean by docs, i didn't get that.

And also plz tell me in which file you have code for "react-without-es6" section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: beginner good first issue type: documentation
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Adding getDerivedStateFromProps to "react-without-es6" section
4 participants
@alejandronanez @gaearon @LadyGaga1208 @Ankit27Agg