Skip to content

/ fathom

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PORT for postgresql config #232

Open
dhuckins opened this issue Feb 19, 2019 · 0 comments · May be fixed by #237
Open

PORT for postgresql config #232

dhuckins opened this issue Feb 19, 2019 · 0 comments · May be fixed by #237

Comments

@dhuckins
Copy link

@dhuckins dhuckins commented Feb 19, 2019

Looks like Port is missing from both the mysql adn postgres config, would it be possible to add it? (seems like a simple enough PR if you'd like)

fathom/pkg/datastore/sqlstore/config.go

Line 10 in da6ffde

type Config struct {

@dhuckins dhuckins linked a pull request that will close this issue Mar 2, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

add port to mysql and postgres config
1 participant
@dhuckins
You can’t perform that action at this time.