tpm

Expected behaviour

I expected the VM to come up normally, just exchanging NAT IP by bridge IP

Actual behaviour

When adding the bridge="br0" line to the conf file, when trying to start VM immediately a "Connect to SPICE" window pops up asking for Hostname, Port, TLS Port and showing recent connections that obviously now don't work anymore.

As don't know much about spice, maybe

This issue tracks the different things that can be done to improve the code quality. If you want to fix some one of the issues please comment on this issue, so I can update it.

pylint

We currently have a large list of warnings that we ignore. Those have to be reviewed and removed where possible.

Current warnings:

• W1509: #932
• C0103
• C0115:
• C0116:
• C0

Environment

Board: APL UPSquared with PTT
OS: Ubuntu 20.04 (opensc 0.20.0-3)
tpm2-tss: 4.2.1 (tarball)
tpm2-pkcs11: 1.3.1 (tarball)
tpm2-tools: 4.1.3 (tarball)
tpm2-abrmd: Not installed
Token initialized with tpm2_ptool with label tpmhsm

Error message

id=`uuidgen | tr -d -`
pkcs11-tool --module /usr/lib/libtpm2_pkcs11.so --token-label tpmhsm --login --pin (redacted) --key-

This is a good first issue for someone who wants to get into OSS/TPM development.

We need a simple example to show TPM signature verification.

We already have examples for TPM2_Quote and TPM2_GetTime that can be used to generate signed TPM blob(data).

Details:

• Both TPM2_Quote and TPM2_GetTime produce similar output using TPM2B_ATTEST and TPMT_SIGNATURE structures.
• The TPMT_SIGNATU

The if statement always evaluates to true:

https://github.com/tpm2-software/tpm2-tss-engine/blob/8acc6181f27c1b60263ab9ad5e28f4638e0460ed/src/tpm2-tss-engine-common.c#L490