Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse three-letter timezones from rfc822 in cookies #349
Conversation
Chrome and Safari (at the time of writing), both seem to ignore cookies that use numeric timezones
|
Thanks, I've added this to the list. If you find any supporting evidence between now and when I investigate, please add it to the thread. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kipz commentedSep 20, 2018
Although the various specs prefer [1] numeric timezones allowed by rfc822 [2] for the cookie expires field, some browsers discard cookies with dates in this format (latest chrome and safari at the time of writing). Firefox does seem to respect this aspect of the specs.
I don't currently have any other supporting evidence, except that @neilprosser I have tried this on Linux with Chrome, Chromium and Firefox, and on OSx with Safari, Chrome and Firefox.
[1] https://tools.ietf.org/html/rfc1123#section-5.2.14
[2] https://tools.ietf.org/html/rfc822#section-5.1
Kudos to @neilprosser for spotting this!