Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change seq2seq import names #42

Merged
merged 1 commit into from Jul 19, 2019
Merged

Change seq2seq import names #42

merged 1 commit into from Jul 19, 2019

Conversation

@egens
Copy link
Contributor

@egens egens commented Jul 18, 2019

Had the #37 problem. It looks like on in current version of tensorlayer import names changed.

These imports work with
tensorflow 2.0.0-beta1
tensorlayer 2.1.0

Had the #37 problem. It looks like on in current version of tensorlayer import names changed.

These imports work with 
tensorflow 2.0.0-beta1
tensorlayer 2.1.0
@egens
Copy link
Contributor Author

@egens egens commented Jul 19, 2019

@zsdonghao tensorlayer.models
https://github.com/tensorlayer/tensorlayer/tree/master/tensorlayer/models
have lowercased module seq2seq instead of Seq2seq. And there is no Seq2seqLuongAttention module but Seq2seqLuongAttention class in seq2seq_with_attention module.

@egens
Copy link
Contributor Author

@egens egens commented Jul 19, 2019

Yeah, you provide class names that I use in my commit also. But on import you provide module names that are consistent with file names instead. And they changed in the last tensorlayer version. For example there is no such class Seq2seq_Attention that was imported before my commit.

@zsdonghao zsdonghao merged commit a3d1cfa into tensorlayer:master Jul 19, 2019
1 check passed
1 check passed
WIP Ready for review
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.