[postfix] set hostname via docker-compose #4353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent setting myhostname in main.cf file, which is git tracked Signed-off-by: Kristian Feldsam <feldsam@gmail.com>
|
I think there was a major problem with this regarding DNS lookups. How does acme-mailcow handle this? How long have you been running it? Please don't tell me it's untested. :) That's for an issue then. |
|
this is why I asking you about your opinion :) I tested it only few minutes :) I consider this as discussion with code example. what doest acme have with postfix hostname? |
|
As long as it isn’t merged it is fine.
You may want to check if any other container resolves the hostname to Postfix then.
… Am 01.12.2021 um 21:05 schrieb Kristian Feldsam ***@***.***>:
this is why I asking you about your opinion :) I tested it only few minutes :) I consider this as discussion with code example.
what doest acme have with postfix hostname?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
hi, I tested using ping in Sogo and Dovecot and it working good when I try to ping FQDN it works also correctly |
|
I will not merge unless it is better tested. That’s a change that may be critical. Please also test acme-mailcow etc.
… Am 02.12.2021 um 13:38 schrieb Kristian Feldsam ***@***.***>:
hi, I tested using ping in Sogo and Dovecot and it working good
***@***.***:/# ping postfix
PING postfix(mailcowdockerized_postfix-mailcow_1.mailcowdockerized_mailcow-network (fd4d:6169:6c63:6f77::d)) 56 data bytes
64 bytes from mailcowdockerized_postfix-mailcow_1.mailcowdockerized_mailcow-network (fd4d:6169:6c63:6f77::d): icmp_seq=1 ttl=64 time=0.078 ms
64 bytes from mailcowdockerized_postfix-mailcow_1.mailcowdockerized_mailcow-network (fd4d:6169:6c63:6f77::d): icmp_seq=2 ttl=64 time=0.146 ms
64 bytes from mailcowdockerized_postfix-mailcow_1.mailcowdockerized_mailcow-network (fd4d:6169:6c63:6f77::d): icmp_seq=3 ttl=64 time=0.109 ms
^C
--- postfix ping statistics ---
3 packets transmitted, 3 received, 0% packet loss, time 62ms
rtt min/avg/max/mdev = 0.078/0.111/0.146/0.027 ms
***@***.***:/# ping -4 postfix
PING postfix (172.22.1.253) 56(84) bytes of data.
64 bytes from mailcowdockerized_postfix-mailcow_1.mailcowdockerized_mailcow-network (172.22.1.253): icmp_seq=1 ttl=64 time=0.207 ms
64 bytes from mailcowdockerized_postfix-mailcow_1.mailcowdockerized_mailcow-network (172.22.1.253): icmp_seq=2 ttl=64 time=0.083 ms
64 bytes from mailcowdockerized_postfix-mailcow_1.mailcowdockerized_mailcow-network (172.22.1.253): icmp_seq=3 ttl=64 time=0.114 ms
64 bytes from mailcowdockerized_postfix-mailcow_1.mailcowdockerized_mailcow-network (172.22.1.253): icmp_seq=4 ttl=64 time=0.146 ms
when I try to ping FQDN it works also correctly
***@***.***:/# ping maildev.feldhost.cz
PING maildev.feldhost.cz (185.174.168.25) 56(84) bytes of data.
64 bytes from maildev.feldhost.cz (185.174.168.25): icmp_seq=1 ttl=64 time=0.073 ms
64 bytes from maildev.feldhost.cz (185.174.168.25): icmp_seq=2 ttl=64 time=0.122 ms
^C
--- maildev.feldhost.cz ping statistics ---
2 packets transmitted, 2 received, 0% packet loss, time 62ms
rtt min/avg/max/mdev = 0.073/0.097/0.122/0.026 ms
***@***.***:/# ping -6 maildev.feldhost.cz
PING maildev.feldhost.cz(maildev.fedlhost.cz (2a0b:a900::b9ff:feae:a819)) 56 data bytes
64 bytes from maildev.fedlhost.cz (2a0b:a900::b9ff:feae:a819): icmp_seq=1 ttl=64 time=0.057 ms
64 bytes from maildev.fedlhost.cz (2a0b:a900::b9ff:feae:a819): icmp_seq=2 ttl=64 time=0.099 ms
64 bytes from maildev.fedlhost.cz (2a0b:a900::b9ff:feae:a819): icmp_seq=3 ttl=64 time=0.104 ms
^C
--- maildev.feldhost.cz ping statistics ---
3 packets transmitted, 3 received, 0% packet loss, time 41ms
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
feldsam
force-pushed
the
staging
branch
2 times, most recently
from
2aead31
to
880a68d
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
milkmaker
added
the
stale
|
I have to test it, need time |
milkmaker
removed
the
stale
|
I can and would join the test if you tell me on what I'll have to look for |
DerLinkman
added
enhancement
neverstale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
@andryyy hi, what you think about this change? I like to prevent setting myhostname in main.cf file, which is git tracked and make my git repo not clean and I have to do chekout before update. I don't use alltimes update.sh, especially when there are small changes in only web. Yes, I know I can do "assume-unchaged", but this is cleaner in my opinion.
I tested it using
docker-compose exec postfix-mailcow bash -c 'postconf|grep myhostname'and I also try to ping "postfix" hostname from SOGo, so it doesnt breaks internal networking and name resolution.Signed-off-by: Kristian Feldsam feldsam@gmail.com