Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVRO-3093: Stop releasing avro-python3 package #1165

Merged
merged 2 commits into from Apr 1, 2021
Merged

AVRO-3093: Stop releasing avro-python3 package #1165

merged 2 commits into from Apr 1, 2021

Conversation

subhashb
Copy link
Contributor

@subhashb subhashb commented Mar 30, 2021

With the deprecation notice in place for some time, we can stop maintaining and releasing avro-python3 package along with other SDKs

Closes: https://issues.apache.org/jira/browse/AVRO-3093

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    NA

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    NA

@subhashb
AVRO-3093: Stop releasing avro-python3 code
6513c13 
With the deprecation notice in place for some time, we can stop maintaining
and releasing `avro-python3` package along with other SDKs

Closes: https://issues.apache.org/jira/browse/AVRO-3093
@github-actions github-actions bot added the build label Mar 30, 2021
kojiromike
kojiromike reviewed Mar 30, 2021
View changes
Copy link
Contributor

@kojiromike kojiromike left a comment

If the interop stuff works this is great

@kojiromike
Copy link
Contributor

@kojiromike kojiromike commented Mar 30, 2021

It's hard to tell from iOS GitHub. Did the interop tests run? Can we do something to explicitly trigger those tests?

@RyanSkraba
Copy link
Contributor

@RyanSkraba RyanSkraba commented Mar 30, 2021

I'm doing a full ./build.sh dist on my local machine to check all languages interop (using the buster docker image from #1155)

@subhashb
Copy link
Contributor Author

@subhashb subhashb commented Mar 30, 2021

Thank you, @RyanSkraba!

@kojiromike Triggered python interop tests by making a small documentation change in the lang/py directory (the PR had to be labeled python to trigger tests). All interop tests passed. 👍

@RyanSkraba
Copy link
Contributor

@RyanSkraba RyanSkraba commented Mar 30, 2021

I can confirm that all file interop tests pass, but the RPC interop tests break :/ I don't think these are taken into account in the GitHub Actions yet, but you can launch them after building the world: ./share/test/interop/bin/test_rpc_interop.sh

+ py_tool rpcsend http://127.0.0.1:45815 share/test/schemas/simple.avpr add -file share/test/interop/rpc/add/onePlusOne/request.avro
+ PYTHONPATH=lang/py
+ python3 -m avro.tool rpcsend http://127.0.0.1:45815 share/test/schemas/simple.avpr add -file share/test/interop/rpc/add/onePlusOne/request.avro
Traceback (most recent call last):
  File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/rskraba/avro/lang/py/avro/tool.py", line 166, in <module>
    sys.exit(main(sys.argv))
  File "/home/rskraba/avro/lang/py/avro/tool.py", line 157, in main
    send_message(uri, proto, msg, datum)
  File "/home/rskraba/avro/lang/py/avro/tool.py", line 91, in send_message
    url_obj = urllib.parse(uri)
TypeError: 'module' object is not callable

@RyanSkraba
Copy link
Contributor

@RyanSkraba RyanSkraba commented Mar 30, 2021 •
edited

☝️ OK, it looks like this is a bug in the avro.tool left over from python2, and we never noticed because the tool hasn't been used for rpc interop tests.

We can merge this and take care of the py2 tool error later, the CI will be fine -- it's probably even a good idea to have a JIRA for that problem in case anyone ever runs into it (although I can't imagine how...)

(I created AVRO-3100)

@RyanSkraba RyanSkraba merged commit 7c5e429 into apache:master Apr 1, 2021
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kojiromike kojiromike

Assignees
No one assigned
Labels
build Python
Projects
None yet
Milestone
No milestone
3 participants
@subhashb @kojiromike @RyanSkraba