Skip to content

Reset color history to top after choosing new color#15574

Closed
dwight9339 wants to merge 2 commits intomicrosoft:mainfrom
dwight9339:color-picker-history-update
Closed

Reset color history to top after choosing new color#15574
dwight9339 wants to merge 2 commits intomicrosoft:mainfrom
dwight9339:color-picker-history-update

Conversation

@dwight9339
Copy link
Copy Markdown

@dwight9339 dwight9339 commented Jan 16, 2022

Summary of the Pull Request

What is this about:
Issue #15073 History position not updated on adjusting color

What is included in the PR:
Commented where I think a fix should go.

How does someone test / validate:

  1. Scroll color history down
  2. Select new color or edit color in history
  3. History list view should scroll to top

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@dwight9339
Copy link
Copy Markdown
Author

I think I've found the method where I should place the call to reset the history list view but am stumped on how to call the UI component. Please advise.

@htcfreek
Copy link
Copy Markdown
Collaborator

I think it is a method in ColorsHistory. Something like ScrollIntoView()

@Jay-o-Way Jay-o-Way added the Product-Color Picker All things around the Color Picker utility label Jan 16, 2022
@ghost
Copy link
Copy Markdown

ghost commented Jan 19, 2022

CLA assistant check
All CLA requirements met.

@dwight9339
Copy link
Copy Markdown
Author

Following the example described in the top answer here, I've added a handler method that listens for the CollectionChanged event from the bound observable collection. However, when testing this solution the color editor window fails to load after selecting a color. Not seeing any errors in the console so I'm confused why this is happening.

@htcfreek
Copy link
Copy Markdown
Collaborator

@dwight9339
Any updates on this?

@dwight9339
Copy link
Copy Markdown
Author

@htcfreek No progress

@Jay-o-Way
Copy link
Copy Markdown
Collaborator

Hey @dwight9339 how is this going? :-)

@dwight9339
Copy link
Copy Markdown
Author

dwight9339 commented Jul 5, 2022

Hi @Jay-o-Way. Got stuck while working on this back in January and last I knew it was reassigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Product-Color Picker All things around the Color Picker utility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants