Skip to content

Do not use innerHTML when detecting element resize#1608

Closed
petemill wants to merge 1 commit intobvaughn:masterfrom
petemill:remove-inner-html
Closed

Do not use innerHTML when detecting element resize#1608
petemill wants to merge 1 commit intobvaughn:masterfrom
petemill:remove-inner-html

Conversation

@petemill
Copy link

@petemill petemill commented Nov 3, 2020

use of Element.innerHTML will throw an error if the page uses Trusted Types.

Thanks for contributing to react-virtualized!

Before submitting a pull request, please complete the following checklist:

  • The existing test suites (npm test) all pass
  • For any new features or bug fixes, both positive and negative test cases have been added
  • For any new features, documentation has been added
  • For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
  • Format your code with prettier (yarn run prettier).
  • Run the Flow typechecks (yarn run typecheck).

Here is a short checklist of additional things to keep in mind before submitting:

  • Please make sure your pull request description makes it very clear what you're trying to accomplish. If it's a bug fix, please also provide a failing test case (if possible). In either case, please add additional unit test coverage for your changes. :)
  • Be sure you have notifications setup so that you'll see my code review responses. (I may ask you to make some adjustments before merging.)

use of Element.innerHTML will throw an error if the page uses Trusted Types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant