Skip to content
#

mozilla

Here are 474 public repositories matching this topic...

Mugurell
Mugurell commented Apr 11, 2022

There are placed in our unit tests where Mockito mocks are used and this is causing intermittent test fails.

Saw this issue and fixed two cases on mozilla-mobile/fenix#24620, today I saw [another occurrence](https://firefoxci.taskcluster-artifacts.net/OmWdljybRhGtBDdPjfFisQ/0/public/reports/test/testDebugUnitTest/classes/org.mozilla.fenix.wifi.WifiConnectionMonitorTest.h

good first issue help wanted eng:intermittent-test needs:triage
st3fan
st3fan commented Jan 7, 2022

In URLExtensions.swift we have isIPv4 and isIPv6 functions. The first uses a regex and the second just checks for the presence of a : in the string. Let's replace this with a call to inet_pton() to let the OS parse the address instead - delegating to a trusted OS function will be more robust.

Example at https://stackoverflow.com/questions/35056268/how-to-use-swift-convert-string-to-ip

Improve this page

Add a description, image, and links to the mozilla topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the mozilla topic, visit your repo's landing page and select "manage topics."

Learn more