Force the bundle major version to be over 3000 #12819
Merged
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before #12691, the msixbundle version was of the format YYYY.MM.DD.0. After #12691, it became the same as the build of Terminal it contained. This caused some trouble for _some_ systems: major version 1 is much, much smaller than 2022. Adding 3000 to the major version component, _only for the bundle_, gets around this. Ugh. Fixes #12816.
msftbot
bot
added
Issue-Bug
DHowett
reviewed
Apr 4, 2022
build/pipelines/release.yml
Outdated
| $Files | % { Move-Item -Verbose $_.Directory $_.Directory.Parent.Parent -EA:Ignore } | ||
| pwsh: true | ||
| # - task: TouchdownBuildTask@1 |
There was a problem hiding this comment.
NFCI commit, will be reverted
|
|
This reverts commit a27ff31.
DHowett
requested review from
zadjii-msft and
miniksa
and removed request for
zadjii-msft
zadjii-msft
approved these changes
Apr 4, 2022
There is a risk that using this version number will fail because it is
thousands of numbers less than "2022". We'll have to see if the store
rolls it out properly
Narrator: it did not
|
@msftbot merge this in 1 minute |
msftbot
bot
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
DHowett
added a commit
that referenced
this issue
Apr 4, 2022
Before #12691, the msixbundle version was of the format YYYY.MM.DD.0. After #12691, it became the same as the build of Terminal it contained. This caused some trouble for _some_ systems: major version 1 is much, much smaller than 2022. Adding 3000 to the major version component, _only for the bundle_, gets around this. Ugh. Fixes #12816. (cherry picked from commit bc6bf15) Service-Card-Id: 80144497 Service-Version: 1.13
DHowett
added a commit
that referenced
this issue
Apr 4, 2022
Before #12691, the msixbundle version was of the format YYYY.MM.DD.0. After #12691, it became the same as the build of Terminal it contained. This caused some trouble for _some_ systems: major version 1 is much, much smaller than 2022. Adding 3000 to the major version component, _only for the bundle_, gets around this. Ugh. Fixes #12816. (cherry picked from commit bc6bf15) Service-Card-Id: 80144496 Service-Version: 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Before #12691, the msixbundle version was of the format YYYY.MM.DD.0.
After #12691, it became the same as the build of Terminal it contained.
This caused some trouble for some systems: major version 1 is much,
much smaller than 2022.
Adding 3000 to the major version component, only for the bundle, gets
around this. Ugh.
Fixes #12816.