Skip to content

Conversation

@maflcko
Copy link

@maflcko maflcko commented Apr 6, 2022

@sipa
Copy link
Owner

sipa commented Apr 6, 2022

ACK 20854df

@sipa sipa merged commit ebf710b into sipa:master Apr 6, 2022
@maflcko maflcko deleted the main branch April 6, 2022 14:06
@maflcko
Copy link
Author

maflcko commented Apr 6, 2022

Is the goal to mirror all changes or is the goal to remove the Bitcoin Core stuff here, now that the stuff has been added to Bitcoin Core?

@sipa
Copy link
Owner

sipa commented Apr 6, 2022

I think the goal is to first get everything here into Bitcoin Core (except the compiler/website). Selective deleting things here I think would complicate testing (and remove the ability to e.g. compile the miniscript compiler here). @darosior thoughts?

@darosior
Copy link
Contributor

darosior commented Apr 6, 2022

I agree i don't think deleting the code from here makes a lot of sense. I expect a bit more movements here with Tapscript, but after that i don't expect the code shared between this repo and the Bitcoin Core one to change much.
So eventually i think it'll be worth the small maintenance burden of keeping this repo in sync with Bitcoin Core. And who knows, someone might want to make it an independent library at some point? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants