Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdk:a11y): add focus monitor #489

Merged
merged 1 commit into from Nov 3, 2021
Merged

feat(cdk:a11y): add focus monitor #489

merged 1 commit into from Nov 3, 2021

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Nov 3, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

@idux-bot idux-bot bot commented Nov 3, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

@codecov codecov bot commented Nov 3, 2021

Codecov Report

Merging #489 (f970221) into main (ff1ca43) will decrease coverage by 0.27%.
The diff coverage is 47.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
- Coverage   80.63%   80.36%   -0.28%     
==========================================
  Files         272      275       +3     
  Lines        7106     7149      +43     
  Branches     1536     1403     -133     
==========================================
+ Hits         5730     5745      +15     
- Misses       1376     1404      +28
Impacted Files Coverage Δ
packages/cdk/scroll/src/virtual/VirtualHolder.tsx 86.77% <ø> (ø)
packages/cdk/scroll/src/virtual/types.ts 50.00% <ø> (ø)
packages/cdk/utils/src/composable.ts 15.38% <15.38%> (ø)
...ages/cdk/platform/src/features/passiveListeners.ts 33.33% <33.33%> (ø)
packages/cdk/platform/src/features/shadowDom.ts 45.45% <45.45%> (ø)
packages/cdk/utils/src/vNode.ts 88.88% <69.23%> (+1.58%) ⬆️
packages/cdk/popper/src/hooks.ts 98.68% <100.00%> (ø)
packages/cdk/scroll/src/virtual/VirtualScroll.tsx 100.00% <100.00%> (ø)
packages/cdk/utils/src/convert.ts 100.00% <100.00%> (ø)
packages/components/message/src/Message.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff1ca43...f970221. Read the comment docs.

@danranVm danranVm merged commit fcb9d8a into IDuxFE:main Nov 3, 2021
8 of 10 checks passed
@danranVm danranVm deleted the feat-a11y branch Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@danranVm