Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to notebook cannot distinguish notebooks with the same name #6167

Open
steel-steven-87 opened this issue Feb 16, 2022 · 3 comments
Open

Move to notebook cannot distinguish notebooks with the same name #6167

steel-steven-87 opened this issue Feb 16, 2022 · 3 comments
Labels
enhancement good first issue medium

Comments

@steel-steven-87
Copy link

@steel-steven-87 steel-steven-87 commented Feb 16, 2022

Environment

Joplin version: 2.6.10
Platform: Linux

Steps to reproduce

  1. Create a notebook structure like this:
  • Project 1
    • Archived
  • Project 2
    • Archived
  1. Create a note.
  2. Use "Move to notebook" option.
  3. Type "archived" in the search box.
  4. It is not possible to distinguish which parent the child notebook belongs to, see the image:
    screenshot

Describe what you expected to happen

When you use the search function, it should be possible to distinguish between those notebooks, e.g., by providing the path like this:

  • Project 1 > Archives
  • Project 2 > Archives

Ideally the matched string would be highlighted. This is leaning more towards a feature request, but if anyone fixes this, it would be a nice addition:

  • Project 1 > Archives
  • Project 2 > Archives
@steel-steven-87 steel-steven-87 added the bug label Feb 16, 2022
@laurent22 laurent22 added enhancement good first issue medium and removed bug labels Feb 16, 2022
@khareyash05
Copy link

@khareyash05 khareyash05 commented Feb 17, 2022

I would like to work on this issue

@tessus
Copy link
Collaborator

@tessus tessus commented Feb 17, 2022

Why are you telling us this? ;-) Just make sure that you read the contribution guidelines and create a PR.

@kshitij86
Copy link

@kshitij86 kshitij86 commented Feb 19, 2022

@steel-steven-87 Can say I can reproduce this on Ubuntu 20.04 dev-build (desktop app). I noticed two things:

  1. If you click the dropdown menu right next to the search bar in "Move to Notebook", the structure of notebooks is preserved and the correct one can be selected. However if you select the sub-notebook, the super-notebook name is not mentioned, so you have no idea which sub-notebook is selected (apologies if I'm the terminology wrong).

  2. I agree with your last suggestion that it'd be great if the search highlighted the string in the search suggestions (kind of like Algolia search) and it'd be better if it always showed the notebook structure to avoid ambiguity in case of duplicate names.

I'll take a better look at this and see how it can be fixed.

@ahmedibrahim404 ahmedibrahim404 mentioned this issue Mar 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tessus @laurent22 @kshitij86 @khareyash05 @steel-steven-87