Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restyle logo width to make translations easier #1817

Open
tesseralis opened this issue Mar 13, 2019 · 8 comments · May be fixed by #3948
Open

Restyle logo width to make translations easier #1817

tesseralis opened this issue Mar 13, 2019 · 8 comments · May be fixed by #3948
Labels
good first issue localization

Comments

@tesseralis
Copy link
Member

@tesseralis tesseralis commented Mar 13, 2019

Currently, the width of the logo is fixed at calc(100% / 6) so that the nav links are flush with the search bar:

Screen Shot 2019-03-12 at 7 33 34 PM

Unfortunately, this leads to cut-offs in some translations with longer words in the nav bar:

Screen Shot 2019-03-12 at 7 38 26 PM

We're currently solving this by just adjusting the width of the logo, but it would be nice to have a solution that doesn't require hard-coding the logo width (e.g. just making the nav bar flush against the search bar)

I'll probably fix it myself when I have time but I figured I'd put this up here in case anyone wants to take a look.
@tesseralis tesseralis mentioned this issue Mar 13, 2019
Merged
@kevjin
Copy link

@kevjin kevjin commented Mar 25, 2019

Hi, I would be interested in taking a look at this issue. Thanks!

@kevjin kevjin mentioned this issue Mar 25, 2019
Closed
@kevjin
Copy link

@kevjin kevjin commented Mar 25, 2019

Added PR #1860 for review, thank you!

@tuantvk
Copy link

@tuantvk tuantvk commented Jun 20, 2019 •
edited

same issues repo vi.reactjs.org
After translate to vietnamese
full_content

@nigiiro-taro
Copy link

@nigiiro-taro nigiiro-taro commented Aug 25, 2021

@tesseralis @tuantvk
Hello, I would like to work on this issue. This will be my first contribution to oss.
@kevjin
You have worked on this issue before, would you mind if I took over?

@akgupta0777
Copy link

@akgupta0777 akgupta0777 commented Sep 28, 2021

@nigiiro-taro go ahead give it a try.

@nigiiro-taro
Copy link

@nigiiro-taro nigiiro-taro commented Oct 5, 2021

Thank you. I try it!

nigiiro-taro added a commit to nigiiro-taro/reactjs.org that referenced this issue Oct 5, 2021
@nigiiro-taro
fix center nav bar between logo and search bar (reactjs#1817)
f236f56
@nigiiro-taro nigiiro-taro linked a pull request that will close this issue Oct 5, 2021
Open
@nigiiro-taro
Copy link

@nigiiro-taro nigiiro-taro commented Oct 6, 2021

@tesseralis @akgupta0777
I sent a pull request.
If possible, could you please give me a review or comment?

@abhay27chauhan
Copy link

@abhay27chauhan abhay27chauhan commented Jan 30, 2022

is this issue resolved i ? I would like to work on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue localization
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Restyle logo width to make translations easier [issue #1817]
6 participants
@tesseralis @kevjin @tuantvk @abhay27chauhan @akgupta0777 @nigiiro-taro