invalid ipv6 host

[LYF1999]

 let uri = "mysql://username:p@ssw0rd@[::1]:5432/database";
 let opts = MySqlConnectOptions::from_str(uri).unwrap();
 println!("{:?}", opts.host); // the opts.host is "[::1]"

sqlx try to use this host to connect at

sqlx/sqlx-core/src/mysql/connection/stream.rs

Line 46 in dfd9cf5

None => Socket::connect_tcp(&options.host, options.port).await?,

but [::1] is a invalid address for tokio::net::TcpStream::connect, which expect a address like ::1 without a []
so, we will get an error failed to lookup address information: Name or service not known

[abonander]

My question is: is this a url crate bug, a Tokio bug, or a SQLx bug?

[jplatte]

I'm pretty sure this is a SQLx bug. The [] are part of a URL containing an IPv6 address, they're not part of the address itself. A type like IpAddr that this is likely parsed into internally won't have parsing code that expects [].

The url crate explicitly documents that the [] are part of the host string, though it's unfortunate that you can so easily shoot yourself in the foot because of that when using the crate.

[abonander]

So the fix here would be to just trim [] from the host string.

[techytoes]

Hi @abonander, I would like to work on this issue if not already been taken. Also, I am new to this organization so can you please share more details regarding the issue. Thanks!