Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC 2 for in-page TOC #1474

Merged
merged 2 commits into from Feb 2, 2017
Merged

POC 2 for in-page TOC #1474

merged 2 commits into from Feb 2, 2017

Conversation

@mdlinville
Copy link
Contributor

@mdlinville mdlinville commented Feb 2, 2017

Proposed changes

This approach is fully liquid. You can configure with:

  • no_toc: true
  • toc_min: 2
  • toc_max: 6

The site defaults are 2 and 3 for the min and max.

This retains the Edit / Request / Support links on the side, as well.

Copy link
Contributor

@londoncalling londoncalling left a comment

I like it.

@mdlinville
Copy link
Contributor Author

@mdlinville mdlinville commented Feb 2, 2017

Had to give up on that last commit for now. At least the JS is getting an overhaul!

@mdlinville
Copy link
Contributor Author

@mdlinville mdlinville commented Feb 2, 2017

This is ready to merge! Thanks @allejo for all of the help in the implementation!

@mdlinville mdlinville merged commit 2a88caa into docker:master Feb 2, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit is being built
Details
deploy/netlify Deploy preview ready!
Details
@mdlinville mdlinville deleted the mdlinville:auto_toc_inpage2 branch Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants