Skip to content
#

canary

Here are 88 public repositories matching this topic...

flagger
chlunde
chlunde commented Feb 8, 2022

Describe the bug

The documentation and some tests uses gw.ns(.svc.cluster.local) for gateways.

I think this is the correct format for istio gateways: <gateway namespace>/<gateway name>

Like here:

https://github.com/fluxcd/flagger/blob/273b05fb24d467c10939389218e6a8ec26d4c70e/test/istio/test-delegation.sh#L41

re. https://istio.io/latest/docs/reference/config/networking/virtua

harikrongali
harikrongali commented Mar 4, 2022

Similar to deployment, Rollout should throw error and shouldn't create the object if the selector is not specified.

Current behavior:
Rollout object gets created with Error status

Expected behavior:
Rollout object shouldn't be allowed to create and throw a validation error

Following file doesn't have selector defined

apiVersion: argoproj.io/v1alpha1
kind: Rollout
metadata:
  n
enhancement good first issue

Improve this page

Add a description, image, and links to the canary topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the canary topic, visit your repo's landing page and select "manage topics."

Learn more