"They've done studies, you know. 60% of the time, it works every time." - Brian Fantana
- Zürich, Switzerland
- https://daviddalbusco.com
- @daviddalbusco
Block or Report
Block or report peterpeterparker
Report abuse
Contact GitHub support about this user’s behavior. Learn more about reporting abuse.
Report abusePinned
2,335 contributions in the last year
Less
More
Contribution activity
April 2022
Created 140 commits in 13 repositories
Created 3 repositories
- peterpeterparker/ic Rust
- peterpeterparker/ic-routing JavaScript
- peterpeterparker/manifest JavaScript
Created a pull request in dfinity/nns-dapp that received 2 comments
fix: filter have no effect after proposal detail page back action
Motivation PR #698 had a missing flow. It indeed did not reset the list of proposals but had for effect to make the changes of the filters ignored …
+56
−21
•
2
comments
Opened 42 other pull requests in 6 repositories
dfinity/nns-dapp
24
merged
1
closed
- fix: filters have no effect after back from detail page
- feat: ignore error "Neuron already voted on proposal."
- fix: proposal filters counter
- feat: "Loading your neurons..." spinner
- feat: init neurons store for voting only once if needed
- feat: chunks get balance calls to ledger
- feat: display fee only on amount step
- style: sort stake neuron information
- feat: new transaction filter selectable accounts
- feat: visually center route spinner
- feat: execute transaction from/to main- and subaccounts
- feat: do not provide "Unspecified" as proposal filter option
- fix: reset proposals filter on back from detail page
- feat: re-filter proposals returned by governance canister
- fix: max new transaction value
- fix: neuron utils wildcard import
- refactor: style padding calc
- feat: implement transaction step "enter amount" and init step "review"
- fix: flutter auto redirect in prod
- feat: new transaction store, context and init amount step
- feat: account address input rules
- feat: init new transaction
- test: fix warnings "<FiltersButton> was created with unknown prop 'data-tid'"
- refactor: move modal tests
- feat: await import dummy proposal script
papyrs/stylo
9
merged
- fix: right click - context menu support
- feat: focusout for iOS devices
- style: paragraph relative and placeholder absolute
- feat: debounce placeholder
- style: color height and alignment in brave and safari
- fix: placeholder position
- style: placeholder and add colors
- fix: delete content backward
- fix: transform very first paragraph
dfinity/nns-js
3
merged
papyrs/ic
2
merged
deckgo/deckdeckgo
2
merged
dfinity/internet-identity
1
merged
Reviewed 56 pull requests in 3 repositories
dfinity/nns-dapp
25 pull requests
- L2-432: Disburse Neuron UI
- L2-357: Add hotkey functionality
- Changelog for release 2022-04-20
- feat: show getProposal error message in toast details
- Feat: Merge neurons functionality
- feat: ignore error "Neuron already voted on proposal."
- refactor: move principal stringifying to nns-dapp
- feat: "Loading your neurons..." spinner
- Feat/request and response logs
- feat: init neurons store for voting only once if needed
- feat: redesign toasts
- Feat/proposals qu error handling
- refactor: notVotedNeurons -> votableNeurons
- Feat: Neuron Detail Manage Errors
- Feat: Merge neurons UI
- feat: new transaction filter selectable accounts
- feat: execute transaction from/to main- and subaccounts
- fix: broken layout of proposal detail long title
- feat: add more content to dummy proposal
- Feat: Neuron detail split
- Chore: Update Svelte Readme
- Release 2022-04-11: Svelte proposals
- L2 354 following neuron card
- fix: remove from selection neurons w/o votingPower
- fix: hidden/cut-off tooltip on mobile
- Some pull request reviews not shown.
dfinity/nns-js
10 pull requests
- Release 0.4.0 on 2022-04-22
- L2 473 filter displaying proposals that by all visible signs should not be shown
- L2-357: Hotkey functionality
- L2-314: Change Deprecated Method to claim neuron
- Revert "Disable shfmt due to installation problems (#81)"
- Feat: Merge Neurons
- feat: add votableNeurons util
- feat: ledger transfer default fee and memo
- Bump minimist from 1.2.5 to 1.2.6
- Feat: Governance Split Neuron
dfinity/internet-identity
1 pull request
Created an issue in papyrs/stylo that received 2 comments
color picker overlay height on brave
Expected Behavior See screenshot, the color picker is not properly sized if used in Brave.
2
comments