Add checks for existing callable at compilation#3451
Conversation
stof
reviewed
Dec 1, 2020
ghost
commented
Dec 1, 2020
| $class = substr($callable, 0, $pos); | ||
| $method = substr($callable, $pos + 2); | ||
| if (!method_exists($class, $method)) { | ||
| if (!method_exists($class, '__callStatic')) { |
Author
There was a problem hiding this comment.
Should this also check for __call? We allow [FQCN, 'nonStaticMethod'] for instance methods even though that is not a legal callable. Is 'FQCN::nonStaticMethod' also legal in context of Twig?
ghost
requested a review
from
Author
|
@fabpot do you have an opinion on this pull request? |
Author
Author
ghost
closed this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3450
Currently Twig does not check if the callable passed to CallExpression is actually a callable.
This pull request adds does checks.
If it is a function it check if it exists. If it is an array indicating a class method, then it also checks for the presence of __call and __callStatic methods.
If the callable does not exist a \LogicException is thrown. (I don't know if this is the appropriate Exception).
I think Twig should check for the existence of callables if it can otherwise it can be quite cumbersome to debug when using caching, since it is possible a wrong path will be compiled. (This happened to me.)
Some unrelated Function/Filter tests broke because they were passing undefined callables so I fixed them. However, the intent was clear to pass an existing callable.