Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI with the GHA new feature #8691

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve CI with the GHA new feature #8691

wants to merge 2 commits into from
+684 −1,413

Conversation

kezhenxu94
Copy link
Member

@kezhenxu94 kezhenxu94 commented Mar 16, 2022 •
edited

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

This PR optimize the following things by using the new feature of GitHub Actions "rerun failed jobs"

  • Bring all common dependencies (like build tar, build docker, sanity check, etc.) of UT, IT, E2E together and only execute them once.
  • Minimize the dependency tree, so when a job failed, we can rerun it and its dependents with minimal resources / time.

The dependency graph looks like this

image

This PR also fixes a problem that cancelled jobs can pass the "Required" CI check context.

@kezhenxu94 kezhenxu94 added this to the 9.0.0 milestone Mar 16, 2022
@kezhenxu94 kezhenxu94 requested a review from wu-sheng Mar 16, 2022
@kezhenxu94 kezhenxu94 force-pushed the ci-improve branch 3 times, most recently from dcaed81 to ae9bf50 Mar 16, 2022
wu-sheng
wu-sheng previously approved these changes Mar 16, 2022
View changes
@wu-sheng
Copy link
Member

@wu-sheng wu-sheng commented Mar 16, 2022

You need to sync the branch manually. It seems you closed the authentication of fork repo update.

wu-sheng
wu-sheng approved these changes Mar 16, 2022
View changes
Copy link
Member

@wu-sheng wu-sheng left a comment

LGTM. The only side effect of this new GHA version, we can't rerun the failed tasks until the whole process is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng

Assignees
No one assigned
Labels
chore CI settings
Projects
None yet
Milestone
9.0.0
Linked issues

Successfully merging this pull request may close these issues.

None yet
2 participants
@kezhenxu94 @wu-sheng