Skip to content

/ apps

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate all images are actually images during the tests #431

Open
MarshallOfSound opened this issue Dec 16, 2017 · 2 comments
Open

Validate all images are actually images during the tests #431

MarshallOfSound opened this issue Dec 16, 2017 · 2 comments
Labels
good first issue

Comments

@MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Dec 16, 2017

We could do a HEAD request to all image URL's to ensure the mimeType returned is actually an image.

This would prevent things like #430 where the URL added didn't actually point to an image 👍

Existing tests: https://github.com/electron/electron-apps/blob/master/test/human-data.js#L100
@MarshallOfSound MarshallOfSound mentioned this issue Dec 16, 2017
Merged
@zeke
Copy link
Member

@zeke zeke commented Dec 20, 2017

Yeah I had a similar thought a while back: #88

We'd need to make sure this check only happens on newly-added (or newly updated) apps, so as to avoid making a jillion network requests. :)
@as900900

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@zeke @MarshallOfSound @as900900
You can’t perform that action at this time.