Allow withMinimum behavior of calcYAxisParameters() to be set as opt… #259
Conversation
…ion for the chart.
|
Can you provide a codesandbox demo of this behaviour, I can't seem to replicate this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Allow withMinimum behavior of
calcYAxisParameters()to be set as option for the chart.Explanation About What Code Achieves:
calcYAxisParameters(), and saw that it has a parameterwithMinimum, but it is set automatically to true if the chart is of type 'line'. My change allows this to be set as a parameter for the chart. If it's not set, it will maintain the current behavior, so there are no breaking changes.Screenshots/GIFs:
Before:


After:
Steps To Test:
withMinimum: falseTODOs: