Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use styled-components in comment-list-item #723

Merged
merged 3 commits into from Feb 13, 2018

Conversation

@chinesedfan
Copy link
Member

@chinesedfan chinesedfan commented Feb 12, 2018

Question Response
Version? v1.4.1
Devices tested? iPhone 6 Simulator
Bug fix? no
New feature? no
Includes tests? no
All Tests pass? yes
Related ticket? #532

Screenshots

Before After
3 pic 2 pic

Description

Based on #557. Thank @MrLoh all the same.

Copy link
Member

@machour machour left a comment

Could you have a look at Travis?

},
});
const Container = styled.View`
padding: 10px 10px 0 0;

This comment has been minimized.

@machour

machour Feb 12, 2018
Member

This seems to cause a Travis build failure, could you have a look?

This comment has been minimized.

@chinesedfan

chinesedfan Feb 12, 2018
Author Member

@machour It is due to my stylelint regular expression. Fixed now.

`;

const ActionButtonIconContainer = styled.View`
padding: 5px 0 10px;

This comment has been minimized.

@machour

machour Feb 12, 2018
Member

And this too

@coveralls
Copy link

@coveralls coveralls commented Feb 12, 2018

Coverage Status

Coverage increased (+0.3%) to 44.478% when pulling 3382fdc on chinesedfan:pr_557 into a9639dc on gitpoint:master.

Copy link
Member

@machour machour left a comment

LGTM, tested on Android and iPhone simulators.

@machour machour merged commit 1947f1c into gitpoint:master Feb 13, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.3%) to 44.478%
Details
@alejandronanez alejandronanez mentioned this pull request Feb 14, 2018
40 of 51 tasks complete
@chinesedfan chinesedfan deleted the chinesedfan:pr_557 branch Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.