Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools] Manifest version 2 is deprecated #24522

Open
Bartel-C8 opened this issue May 9, 2022 · 10 comments
Open

[DevTools] Manifest version 2 is deprecated #24522

Bartel-C8 opened this issue May 9, 2022 · 10 comments

Comments

@Bartel-C8
Copy link

@Bartel-C8 Bartel-C8 commented May 9, 2022

Website or app

https://developer.chrome.com/blog/mv2-transition/

Repro steps

Use latest React DevTools with Electron (Chromium) (18.2.0 / Chromium 100)

  (node:80082) ExtensionLoadWarning: Warnings loading extension at ./node_modules/electron-devtools-vendor/extensions/react-developer-tools:
    Manifest version 2 is deprecated, and support will be removed in 2023. See https://developer.chrome.com/blog/mv2-transition/ for more details.

How often does this bug happen?

Every time

DevTools package (automated)

No response

DevTools version (automated)

No response

Error message (automated)

No response

Error call stack (automated)

No response

Error component stack (automated)

No response

GitHub query string (automated)

No response

@Bartel-C8
Copy link
Author

@Bartel-C8 Bartel-C8 commented May 9, 2022

Redux DevTools issue for reference/inspiration/impact: reduxjs/redux-devtools#1037

@lunaruan lunaruan added Type: Feature Request good first issue and removed Type: Bug Status: Unconfirmed labels May 9, 2022
@lunaruan
Copy link
Contributor

@lunaruan lunaruan commented May 9, 2022

Hey! Thanks so much for the heads up! We've added it to our plans for this year. 😊

@DhairyaBahl
Copy link

@DhairyaBahl DhairyaBahl commented May 9, 2022

@lunaruan I would love to work on this issue. Kindly assign this issue to me.

@lunaruan
Copy link
Contributor

@lunaruan lunaruan commented May 9, 2022

Hey, sure you can take a stab at it!

@mondaychen
Copy link
Contributor

@mondaychen mondaychen commented May 10, 2022

@DhairyaBahl that would be nice! When do you plan to start working on it?

@bvaughn
Copy link
Collaborator

@bvaughn bvaughn commented May 11, 2022

To my knowledge, the last time we investigated manifest v3 – there were blockers for our adopting it. I think maybe the run_at option was missing the "document_start" maybe but I'm not sure?

@DhairyaBahl
Copy link

@DhairyaBahl DhairyaBahl commented May 11, 2022

@mondaychen I will start exploring this issue soon. Since I am a new contributor to React, successful PR may take some time. If this issue needs to be resolved on urgent basis then do let me know.

@mondaychen
Copy link
Contributor

@mondaychen mondaychen commented May 11, 2022

@bvaughn haven't tested but at least it's still in the V3 docs https://developer.chrome.com/docs/extensions/mv3/content_scripts/#run_time

@mondaychen
Copy link
Contributor

@mondaychen mondaychen commented May 11, 2022

@DhairyaBahl there's a timeline for the migration: https://developer.chrome.com/docs/extensions/mv3/mv2-sunset/
We don't want to wait until last minute... I think for now we hope to get it done by September. That's plenty of time if you are starting now.
You can follow the README under the extension package folder to get started. Let me know if you need help!

@mondaychen mondaychen changed the title [DevTools Bug]: Manifest version 2 is deprecated [DevTools] Manifest version 2 is deprecated May 12, 2022
@JadaMonroe
Copy link

@JadaMonroe JadaMonroe commented May 22, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants