Skip to content
#

payments

Here are 1,093 public repositories matching this topic...

C-Otto
C-Otto commented Dec 7, 2021

Background

Inspired by C-Otto/rebalance-lnd#241.

As part of pathfinding, lnd might encounter edges that have a policy specifying a zero CLTV delta (possibly because of no/outdated gossip?). Every time an edge like this is used in the pathfinding code, a warning is logged: https://github.com/lightningnetwork/lnd/blob/290b78e700021e238f7e6bdce6acc80de8d0a64f/routi

beginner good first issue logging P3
therefromhere
therefromhere commented Nov 18, 2019

in WebhookEventTrigger.from_request we log the webhook request IP address, but we extract it in a simplistic way:

https://github.com/dj-stripe/dj-stripe/blob/0dd7925602e9b2ac693391fc9c02c4d87b97f5a9/djstripe/models/webhooks.py#L86-L92

It might be useful to add a settings-overridable function here so that users could use django-ipware (https://github.com/un33k/django-ipware) etc to do a mor

t-bast
t-bast commented Jul 2, 2021

When we return a bitcoin amount, our JSON responses currently specify the unit (btc, sat, msat) in the parameter name, but it's a bit ugly and is missing in some places.

Maybe it would be better to include the unit explicitly in the response. I see two different options:

  • Instead of returning a numeric value, return a string including the unit (e.g. "2500 msat", "0.45 btc", "1.5 mbtc"). The

Improve this page

Add a description, image, and links to the payments topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the payments topic, visit your repo's landing page and select "manage topics."

Learn more