Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use 1es-windows-2019 again" #41590

Merged
merged 1 commit into from May 9, 2022
Merged

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented May 9, 2022

Reverts #41547

@wtgodbe wtgodbe requested review from and dougbu as code owners May 9, 2022
@msftbot msftbot bot added the area-infrastructure label May 9, 2022
@dougbu
Copy link
Member

@dougbu dougbu commented May 9, 2022

What's going wrong at the moment @wtgodbe

dougbu
dougbu approved these changes May 9, 2022
Copy link
Member

@dougbu dougbu left a comment

Saw offline conversation. Are you running any internal validation

@wtgodbe
Copy link
Member Author

@wtgodbe wtgodbe commented May 9, 2022

Here's a test build, but it likely won't try to install Microbuild either: https://dev.azure.com/dnceng/internal/_build/results?buildId=1760563&view=results

@wtgodbe
Copy link
Member Author

@wtgodbe wtgodbe commented May 9, 2022

Actually it did try (and succeed) to install Microbuild, not sure why the other internal build didn't

@wtgodbe wtgodbe merged commit dac643d into main May 9, 2022
23 of 25 checks passed
@wtgodbe wtgodbe deleted the revert-41547-dougbu/1es-windows-2019 branch May 9, 2022
@msftbot msftbot bot added this to the 7.0-preview5 milestone May 9, 2022
@dougbu
Copy link
Member

@dougbu dougbu commented May 9, 2022

We were testing different things because our prior problems w/ the Build.Server.Amd64.VS2019 image was missing a native VS component while the issue w/ 1es-windows-2019 was the cert problem.

The difference was probably my test being an internal PR (https://dev.azure.com/dnceng/internal/_git/dotnet-aspnetcore/pullrequest/22742) and yours being a manual run. Arcade's job.yml skips the Install MicroBuild plugin step for all PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants