-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update Firestore rules #469
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
|
I believe @erickzanardo already has commit access and should be able to help this land. @tvolkert or @Hixie can also get you (and your VGV colleagues) access via https://github.com/flutter/flutter/blob/master/CONTRIBUTING.md. Thanks for your continued work on this, looks great. :) |
|
I like this PR but I think this is not the best conduct. We should have merged #467 and created a new PR for the score change. We can merge this one anyway for now because I really do not mind, but it is not how I would do OSS. |
Sorry about that! Was not the intent. I was working on these in parallel it seems. |
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just leave a small comment on the regex, but ok 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rslgtm
Description
Adding in a few more checks
Type of Change