Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Firestore rules #469

Merged
merged 6 commits into from
May 12, 2022
Merged

fix: update Firestore rules #469

merged 6 commits into from
May 12, 2022

Conversation

tomarra
Copy link
Contributor

@tomarra tomarra commented May 11, 2022

Description

Adding in a few more checks

  • Initials have to be 3 in length and only be capital letters
  • Score needs to be within the valid score window
  • Character needs to match the defined set

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@tomarra tomarra requested a review from erickzanardo as a code owner May 11, 2022 01:23
@google-cla
Copy link

google-cla bot commented May 11, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@eseidelGoogle
Copy link

I believe @erickzanardo already has commit access and should be able to help this land. @tvolkert or @Hixie can also get you (and your VGV colleagues) access via https://github.com/flutter/flutter/blob/master/CONTRIBUTING.md.

Thanks for your continued work on this, looks great. :)

@johnpryan johnpryan enabled auto-merge (squash) May 11, 2022 05:17
@creativecreatorormaybenot

I like this PR but I think this is not the best conduct. We should have merged #467 and created a new PR for the score change.

We can merge this one anyway for now because I really do not mind, but it is not how I would do OSS.

@tomarra
Copy link
Contributor Author

tomarra commented May 11, 2022

I like this PR but I think this is not the best conduct. We should have merged #467 and created a new PR for the score change.

We can merge this one anyway for now because I really do not mind, but it is not how I would do OSS.

Sorry about that! Was not the intent. I was working on these in parallel it seems.

auto-merge was automatically disabled May 11, 2022 13:08

Head branch was pushed to by a user without write access

Copy link
Contributor

@RuiMiguel RuiMiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just leave a small comment on the regex, but ok 👍

Copy link

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

@erickzanardo erickzanardo merged commit c41e41d into flutter:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants