[WIP] Try using call-site aware IR PGO for LLVM #97153

Kobzol · 2022-05-18T21:09:58Z

LLVM has a second mode of PGO, called call-site aware PGO. Let's try if and how it works.

r? @ghost

Kobzol · 2022-05-18T21:10:22Z

@bors try @rust-timer queue

rust-timer · 2022-05-18T21:10:24Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-05-18T21:10:30Z

⌛ Trying commit 15da36b with merge 8851e36...

[WIP] Try using call-site aware IR PGO for LLVM LLVM has a second mode of PGO, called call-site aware PGO. Let's try if and how it works. r? `@ghost`

bors · 2022-05-18T21:46:21Z

💔 Test failed - checks-actions

Kobzol · 2022-05-19T21:10:44Z

@bors try @rust-timer queue

rust-timer · 2022-05-19T21:10:47Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-05-19T21:10:53Z

⌛ Trying commit d183f76 with merge 8730232...

[WIP] Try using call-site aware IR PGO for LLVM LLVM has a second mode of PGO, called call-site aware PGO. Let's try if and how it works. r? `@ghost`

bors · 2022-05-19T22:34:57Z

☀️ Try build successful - checks-actions
Build commit: 8730232 (87302328f42a41865f79dd5d01857803704966db)

rust-timer · 2022-05-19T22:34:59Z

Queued 8730232 with parent c067287, future comparison URL.

rust-timer · 2022-05-19T23:58:01Z

Finished benchmarking commit (8730232): comparison url.

Instruction count

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: 😿 relevant regressions found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	124	82	0	0	124
mean²	7.6%	6.0%	N/A	N/A	7.6%
max	18.1%	16.6%	N/A	N/A	18.1%

Max RSS (memory usage)

Results

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: 😿 relevant regressions found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	231	256	1	0	232
mean²	6.6%	10.8%	-1.1%	N/A	6.6%
max	22.8%	25.1%	-1.1%	N/A	22.8%

Cycles

Results

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: 😿 relevant regressions found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	100	75	1	0	101
mean²	12.3%	9.2%	-1.7%	N/A	12.1%
max	23.5%	26.5%	-1.7%	N/A	23.5%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

number of relevant changes ↩ ↩² ↩³
the arithmetic mean of the percent change ↩ ↩² ↩³

Kobzol · 2022-05-20T19:06:38Z

@bors try @rust-timer queue

rust-timer · 2022-05-20T19:06:41Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-05-20T19:06:48Z

⌛ Trying commit 3736e6b with merge cbed134...

[WIP] Try using call-site aware IR PGO for LLVM LLVM has a second mode of PGO, called call-site aware PGO. Let's try if and how it works. r? `@ghost`

bors · 2022-05-20T21:47:11Z

☀️ Try build successful - checks-actions
Build commit: cbed134 (cbed134b20d1fe82e1106f135cc4383f4021933b)

rust-timer · 2022-05-20T21:47:14Z

Queued cbed134 with parent b5caa5a, future comparison URL.

rust-timer · 2022-05-20T23:38:53Z

Finished benchmarking commit (cbed134): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: 😿 relevant regressions found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	5	14	0	1	5
mean²	1.3%	1.4%	N/A	-3.5%	1.3%
max	1.5%	2.2%	N/A	-3.5%	1.5%

Cycles

Results

Primary benchmarks: mixed results
Secondary benchmarks: 😿 relevant regression found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	1	1	1	0	2
mean²	2.1%	2.3%	-1.0%	N/A	0.5%
max	2.1%	2.3%	-1.0%	N/A	2.1%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

number of relevant changes ↩ ↩²
the arithmetic mean of the percent change ↩ ↩²

Kobzol · 2022-05-21T05:45:54Z

@bors try @rust-timer queue

rust-timer · 2022-05-21T05:45:55Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

rust-timer · 2022-05-21T09:20:54Z

Queued 4f28145 with parent 3b64fe9, future comparison URL.

rust-timer · 2022-05-21T11:51:59Z

Finished benchmarking commit (4f28145): comparison url.

Instruction count

Primary benchmarks: 😿 relevant regression found
Secondary benchmarks: no relevant changes found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	1	0	0	0	1
mean²	0.4%	N/A	N/A	N/A	0.4%
max	0.4%	N/A	N/A	N/A	0.4%

Max RSS (memory usage)

Results

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: 😿 relevant regressions found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	16	52	0	0	16
mean²	1.5%	1.7%	N/A	N/A	1.5%
max	3.0%	4.9%	N/A	N/A	3.0%

Cycles

Results

Primary benchmarks: 🎉 relevant improvements found
Secondary benchmarks: no relevant changes found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	0	0	21	0	21
mean²	N/A	N/A	-1.9%	N/A	-1.9%
max	N/A	N/A	-2.5%	N/A	-2.5%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

number of relevant changes ↩ ↩² ↩³
the arithmetic mean of the percent change ↩ ↩² ↩³

Kobzol · 2022-05-21T15:45:43Z

@bors try @rust-timer queue

rust-timer · 2022-05-21T15:45:44Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-05-21T15:45:51Z

⌛ Trying commit 582e9bc with merge caeb6dc...

[WIP] Try using call-site aware IR PGO for LLVM LLVM has a second mode of PGO, called call-site aware PGO. Let's try if and how it works. r? `@ghost`

bors · 2022-05-21T18:03:31Z

☀️ Try build successful - checks-actions
Build commit: caeb6dc (caeb6dc8dd5a8bfe01904e193e82abed28bc5a42)

rust-timer · 2022-05-21T18:03:33Z

Queued caeb6dc with parent 3b9cf89, future comparison URL.

rust-timer · 2022-05-21T20:00:14Z

Finished benchmarking commit (caeb6dc): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: 😿 relevant regressions found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	26	54	0	0	26
mean²	1.5%	1.7%	N/A	N/A	1.5%
max	2.3%	3.6%	N/A	N/A	2.3%

Cycles

Results

Primary benchmarks: 🎉 relevant improvements found
Secondary benchmarks: 🎉 relevant improvements found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	0	0	28	2	28
mean²	N/A	N/A	-2.3%	-2.4%	-2.3%
max	N/A	N/A	-3.8%	-3.0%	-3.8%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

number of relevant changes ↩ ↩²
the arithmetic mean of the percent change ↩ ↩²

Kobzol · 2022-06-10T16:11:27Z

@bors try @rust-timer queue

rust-timer · 2022-06-10T16:11:28Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-06-10T16:11:34Z

⌛ Trying commit 93ff904 with merge d3b259f...

[WIP] Try using call-site aware IR PGO for LLVM LLVM has a second mode of PGO, called call-site aware PGO. Let's try if and how it works. r? `@ghost`

Kobzol · 2022-07-03T08:14:00Z

@bors try @rust-timer queue

rust-timer · 2022-07-03T08:14:01Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-07-03T08:14:09Z

⌛ Trying commit 44ad613 with merge 731282f819829b43dccdc7437b204705b7aec048...

[WIP] Try using call-site aware IR PGO for LLVM LLVM has a second mode of PGO, called call-site aware PGO. Let's try if and how it works. r? `@ghost`

bors · 2022-07-03T11:33:58Z

☀️ Try build successful - checks-actions
Build commit: 731282f (731282f819829b43dccdc7437b204705b7aec048)

Kobzol · 2022-07-07T07:21:54Z

@bors try @rust-timer queue

rust-timer · 2022-07-07T07:21:55Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-07-07T07:22:03Z

⌛ Trying commit 44ad613 with merge bcd41abefbf14dc1eec130e985171a28a4ccbcd2...

[WIP] Try using call-site aware IR PGO for LLVM LLVM has a second mode of PGO, called call-site aware PGO. Let's try if and how it works. r? `@ghost`

rustbot added the S-waiting-on-perf label May 18, 2022

bors added a commit to rust-lang-ci/rust that referenced this issue May 18, 2022

Auto merge of rust-lang#97153 - Kobzol:pgo-cs, r=<try>

8851e36

[WIP] Try using call-site aware IR PGO for LLVM LLVM has a second mode of PGO, called call-site aware PGO. Let's try if and how it works. r? `@ghost`

bors added the S-waiting-on-author label May 18, 2022

This comment has been minimized.

Sign in to view

bors added a commit to rust-lang-ci/rust that referenced this issue May 19, 2022

Auto merge of rust-lang#97153 - Kobzol:pgo-cs, r=<try>

8730232

[WIP] Try using call-site aware IR PGO for LLVM LLVM has a second mode of PGO, called call-site aware PGO. Let's try if and how it works. r? `@ghost`

rustbot added perf-regression S-waiting-on-review and removed S-waiting-on-perf labels May 19, 2022

rustbot added the S-waiting-on-perf label May 20, 2022

bors added a commit to rust-lang-ci/rust that referenced this issue May 20, 2022

Auto merge of rust-lang#97153 - Kobzol:pgo-cs, r=<try>

cbed134

[WIP] Try using call-site aware IR PGO for LLVM LLVM has a second mode of PGO, called call-site aware PGO. Let's try if and how it works. r? `@ghost`

rustbot removed S-waiting-on-perf perf-regression labels May 20, 2022

rustbot added S-waiting-on-review and removed S-waiting-on-perf labels May 21, 2022

rustbot added the S-waiting-on-perf label May 21, 2022

bors added a commit to rust-lang-ci/rust that referenced this issue May 21, 2022

Auto merge of rust-lang#97153 - Kobzol:pgo-cs, r=<try>

caeb6dc

[WIP] Try using call-site aware IR PGO for LLVM LLVM has a second mode of PGO, called call-site aware PGO. Let's try if and how it works. r? `@ghost`

rustbot removed the S-waiting-on-perf label May 21, 2022

Try LLVM CS PGO

93ff904

Kobzol force-pushed the pgo-cs branch from 582e9bc to 93ff904 Compare Jun 10, 2022

rustbot added the S-waiting-on-perf label Jun 10, 2022

bors added a commit to rust-lang-ci/rust that referenced this issue Jun 10, 2022

Auto merge of rust-lang#97153 - Kobzol:pgo-cs, r=<try>

d3b259f

[WIP] Try using call-site aware IR PGO for LLVM LLVM has a second mode of PGO, called call-site aware PGO. Let's try if and how it works. r? `@ghost`

Update LLVM

44ad613

bors added a commit to rust-lang-ci/rust that referenced this issue Jul 3, 2022

Auto merge of rust-lang#97153 - Kobzol:pgo-cs, r=<try>

731282f

[WIP] Try using call-site aware IR PGO for LLVM LLVM has a second mode of PGO, called call-site aware PGO. Let's try if and how it works. r? `@ghost`

bors added a commit to rust-lang-ci/rust that referenced this issue Jul 7, 2022

Auto merge of rust-lang#97153 - Kobzol:pgo-cs, r=<try>

bcd41ab

[WIP] Try using call-site aware IR PGO for LLVM LLVM has a second mode of PGO, called call-site aware PGO. Let's try if and how it works. r? `@ghost`

[WIP] Try using call-site aware IR PGO for LLVM #97153

[WIP] Try using call-site aware IR PGO for LLVM #97153

Kobzol commented May 18, 2022

Kobzol commented May 18, 2022

rust-timer commented May 18, 2022

bors commented May 18, 2022

bors commented May 18, 2022

This comment has been minimized.

Kobzol commented May 19, 2022

rust-timer commented May 19, 2022

bors commented May 19, 2022

bors commented May 19, 2022

rust-timer commented May 19, 2022

rust-timer commented May 19, 2022

Kobzol commented May 20, 2022

rust-timer commented May 20, 2022

bors commented May 20, 2022

bors commented May 20, 2022

rust-timer commented May 20, 2022

rust-timer commented May 20, 2022

Kobzol commented May 21, 2022

rust-timer commented May 21, 2022

rust-timer commented May 21, 2022

rust-timer commented May 21, 2022

Kobzol commented May 21, 2022

rust-timer commented May 21, 2022

bors commented May 21, 2022

bors commented May 21, 2022

rust-timer commented May 21, 2022

rust-timer commented May 21, 2022

Kobzol commented Jun 10, 2022

rust-timer commented Jun 10, 2022

bors commented Jun 10, 2022

Kobzol commented Jul 3, 2022

rust-timer commented Jul 3, 2022

bors commented Jul 3, 2022

bors commented Jul 3, 2022

Kobzol commented Jul 7, 2022

rust-timer commented Jul 7, 2022

bors commented Jul 7, 2022

[WIP] Try using call-site aware IR PGO for LLVM #97153

Are you sure you want to change the base?

[WIP] Try using call-site aware IR PGO for LLVM #97153

Conversation

Kobzol commented May 18, 2022

Kobzol commented May 18, 2022

rust-timer commented May 18, 2022

bors commented May 18, 2022

bors commented May 18, 2022

This comment has been minimized.

Kobzol commented May 19, 2022

rust-timer commented May 19, 2022

bors commented May 19, 2022

bors commented May 19, 2022

rust-timer commented May 19, 2022

rust-timer commented May 19, 2022

Footnotes

Kobzol commented May 20, 2022

rust-timer commented May 20, 2022

bors commented May 20, 2022

bors commented May 20, 2022

rust-timer commented May 20, 2022

rust-timer commented May 20, 2022

Footnotes

Kobzol commented May 21, 2022

rust-timer commented May 21, 2022

rust-timer commented May 21, 2022

rust-timer commented May 21, 2022

Footnotes

Kobzol commented May 21, 2022

rust-timer commented May 21, 2022

bors commented May 21, 2022

bors commented May 21, 2022

rust-timer commented May 21, 2022

rust-timer commented May 21, 2022

Footnotes

Kobzol commented Jun 10, 2022

rust-timer commented Jun 10, 2022

bors commented Jun 10, 2022

Kobzol commented Jul 3, 2022

rust-timer commented Jul 3, 2022

bors commented Jul 3, 2022

bors commented Jul 3, 2022

Kobzol commented Jul 7, 2022

rust-timer commented Jul 7, 2022

bors commented Jul 7, 2022