fix: support installing dependencies on non-ubuntu.#14010
Merged
aslushnikov merged 2 commits intomicrosoft:mainfrom May 10, 2022
Merged
fix: support installing dependencies on non-ubuntu.#14010aslushnikov merged 2 commits intomicrosoft:mainfrom
aslushnikov merged 2 commits intomicrosoft:mainfrom
Conversation
dgozman
approved these changes
May 9, 2022
We should not fast-return if someone tries to run `npx playwright install-deps` on Debian. Instead, we should warn users, fallback to Ubuntu 20.04 dependencies, and proceed.
aslushnikov
force-pushed
the
support-install-deps-on-non-ubuntu
branch
from
d58359f to
9948993
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should not fast-return if someone tries to run
npx playwright install-depson Debian. We regressed this in our last release.Instead, we should warn users, fallback to Ubuntu 20.04 dependencies,
and proceed.