SILCombine: Handle result conversions for apply (convert_function) peephole #58713
+226
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please benchmark |
…ephole If a `convert_function` instruction operates on a function with indirect results, or changes the type of direct results, then we can transform an application of the converted function into an application of the original function followed by bitwise conversions of the results, just like we have done for arguments. Now that closures are emitted at their context abstraction level, they are more likely to be emitted with indirect results, so the inability to simplify function conversions in this case would lead to missed inlining opportunities we used to take.
|
@swift-ci benchmark |
Performance (x86_64): -O
Code size: -OPerformance (x86_64): -Osize
Code size: -OsizePerformance (x86_64): -Onone
Code size: -swiftlibs |
instead of bitcasting the original type. Once the original tuple value is rewritten, the projected element will be the type we want, so the original instruction would be invalid anyway, and we can make a new instruction with the correct type directly.
jckarter
force-pushed
the
sil-combiner-apply-result-conversions
branch
from
601486d
to
2a668b9
Compare
jckarter
changed the title
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If a
convert_functioninstruction operates on a function with indirectresults, or changes the type of direct results, then we can transform
an application of the converted function into an application of the
original function followed by bitwise conversions of the results, just
like we have done for arguments. Now that closures are emitted at their
context abstraction level, they are more likely to be emitted with
indirect results, so the inability to simplify function conversions
in this case would lead to missed inlining opportunities we used to
take.