Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EE_PROXY_TYPE to be replaced by a utiliy function #1388

Open
mrrobot47 opened this issue Feb 6, 2019 · 0 comments
Open

EE_PROXY_TYPE to be replaced by a utiliy function #1388

mrrobot47 opened this issue Feb 6, 2019 · 0 comments

Comments

@mrrobot47
Copy link
Member

@mrrobot47 mrrobot47 commented Feb 6, 2019

Currently, EE_PROXY_TYPE is a constant, which is the container id of the global nginx-proxy container. It is computed every time during the initialization of an command as it is present in the runner.

The command executed for it is time consuming and also required by only a handful of commands, hence it should not be in the runner. Instead it can be replaced by a utility function which computes it's value only when required.

Once the value is found for the first time, it can be stored in a constant, and on next call is_defined function can be used in the function to check if the value is already there, to skip the time consuming computation for the second time.

@mrrobot47 mrrobot47 created this issue from a note in v4 Maintenance Releases (Backlog) Feb 6, 2019
0xRenegade added a commit to 0xRenegade/easyengine that referenced this issue Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants