Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow semicolon in the href of Link header #5464
Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ibnesayeed commentedMay 19, 2020
Semicolons are valid characters in URIs, splitting them while parsing the
Linkheader results in unexpected token and wrongurlattribute (notice;oldid=934259284portion the below example).This PR attempts to fix current parsing issue and also renames a variable to better reflect the purpose of it.
I would note here that this parser still is far from perfect and can be better implemented using state machine.