Horizontal bracket guides break on wrapped lines in first column, if editor.wrappingIndent == "same"

[ferdnyc]

Issue Type: Bug

Demonstration

1. Set the editor language to C++
2. Set editor.guides.bracketPairsHorizontal to true
3. Set editor.wrappingIndent to same
4. Type/paste the Sample code below
5. Resize the editor window so that it is narrower than the line of code provided
6. Note that the horizontal bracket underline stops at the end of the first line, when the (soft-wrapped) line break occurs.

Verification

1. Change editor.wrappingIndent to indent
2. Note that the horizontal bracket underline now continues onto the wrapped second line.

Sample code demonstrating problem

void SomeClassImplementation::my_really_long_function_name(SomeClassImplementation input_instance, const SomeOtherClass& parameter_instance) { }

VS Code version: Code 1.67.0 (57fd6d0, 2022-05-04T12:08:42.978Z)
OS version: Linux x64 5.17.4-200.fc35.x86_64
Restricted Mode: No

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-2400 CPU @ 3.10GHz (4 x 3192)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: disabled_off opengl: enabled_on rasterization: disabled_software raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: disabled_software video_encode: disabled_software vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	7, 6, 6
Memory (System)	19.50GB (1.32GB free)
Process Argv	misc-utils/hardlink.1.adoc --crash-reporter-id 70502e77-0823-4a70-9602-0e2581de41fd
Screen Reader	no
VM	0%
DESKTOP_SESSION	gnome
XDG_CURRENT_DESKTOP	GNOME
XDG_SESSION_DESKTOP	gnome
XDG_SESSION_TYPE	x11

Extensions: none

[ferdnyc]

editor.wrappingIndent == "same"

editor.wrappingIndent == "indent"

[ferdnyc]

Update: Note that this only occurs if the wrapped line starts in the left-most column. Indented, wrapped lines are not affected, regardless of editor.wrappingIndent setting.

[hediet]

Thanks for reporting this! I think it shouldn't be too hard to fix. If you like, we'd be happy for a PR that fixes this!

[MonadChains]

Hi, I found the snippet that produces the bug:

vscode/src/vs/editor/common/viewModel/viewModelLines.ts

Lines 575 to 580 in 2e3c24c

	for (const viewLineInfo of group.viewLines) {
	if (viewLineInfo.isWrappedLineContinuation && this.getMinColumnOfViewLine(viewLineInfo) === 1) {
	// Don't add indent guides when the wrapped line continuation has no wrapping-indentation.
	resultPerViewLine.push([]);
	} else {
	const bracketGuides = bracketGuidesPerModelLine[viewLineInfo.modelLineNumber - modelRangeStartLineNumber];

The if statement controls if the first character of the wrapped line is in column 0. If so, then it ignores the guides for that line.
By simply removing the if statement the result is the following:

It seems that this solves the bug. Given my limited knowledge of the codebase, before opening a pull request, it would be better to clarify the purpose of the if statement as it is not fully clear to me. Should it suppress possible vertical bracket guides in case of wrapped lines? Was it added to address a specific bug?