Noticed this in reviewing #3165. In determining if an element is focused, axe-core looks at the disabled attribute. However it doesn't check if that attribute is allowed for the node. So the following link is incorrectly determined as not focusable:
<a href="foo.html" disabled>Hello</a>This bug exists in lib/commons/dom/focus-disabled.js. The fix is to check `vNode.props.nod
Running the WAVE plugin shows not all text has sufficient contrast, and an empty link is present, these are minor issues and potentially false positives, as the site may serve as an example for others it would be great if at least all errors from automated tests are resolved.
Running a tool such as the WAVE plugin on Chrome shows no errors.
Today I received a question regarding failure of hint to check the html file. This was the error:
Run npx hint .
AnalyzerError: Cannot read property 'getLocation' of undefined
at Analyzer.analyze (/home/runner/work/Awesome-Books/Awesome-Books/node_modules/hint/dist/src/lib/analyzer.js:151:23)
at runNextTicks (internal/process/task_queues.js:62
Really love this library, especially all the accessibility considerations built in! One thing I've noticed in implementing it though is an error from accessibility validators for a missing aria-valuenow property on both the Color and Hue sliders.
I had an explore of the MDN docs for the two properties
Add a description, image, and links to the a11y topic page so that developers can more easily learn about it.
To associate your repository with the a11y topic, visit your repo's landing page and select "manage topics."
Expected Behavior
defaultModeis used in Grommet component along withthemeModeprop to determine initial theme mode between dark and light themes. As this property is used by Grommet Theme Designer, Grommet HPE Theme and in HPE Design System I would expect it to