Automate timezone updates

[MylesBorins]

This happens very infrequently, but would be great to make this automated

Follow up to nodejs/Release#576

[srl295]

if you need help with the icu side in CI lmk

[BethGriggs]

Curious if we should consider moving this to nodejs/node (and potentially tagging with good first issue?). The automation would be on that repository, and this issue would probably get more visibility there.

[srl295]

@BethGriggs probably a good idea.

[srl295]

^ my offer stands

[Ayushi15-Vamne]

Hey @MylesBorins,
Can you please brief little more where that issue replicating.
Thanks

[MylesBorins]

we embed icu in Node.js which has timezone information embedded. This timezone data can end up being updated separately from the icu dependency being updated, this is especially important for LTS versions of Node.js which may not get ICU updates regularly. It is important that the timezone data is up to date or it can cause programming erorrs or issues with services.

This issue referenced in the original post does a good job of explaining how things can go bad.

[rapaktech]

I'm interested in solving this issue. Where do I sign up?

[bnoordhuis]

@rapaktech Right here. :-)

Node's tzdata comes from ICU. ICU's binary data file is stored in deps/icu-small/source/data/in. Somehow that file should be updated to include newer tzdata - maybe by updating ICU's data/zone/* files from icu4c-71_1-data.zip and building a new .dat file?

[srl295]

ICU has a whole guide on this topic, https://unicode-org.github.io/icu/userguide/datetime/timezone/#updating-the-time-zone-data And I thought node has a guide as well?

[rapaktech]

Thanks @bnoordhuis & @srl295. Gone through the resources you shared, and I think I understand what to do.

This is my first time contributing here and I'm not sure what the contributing guideline is. Would appreciate any pointers. Thanks.

[srl295]

Thanks @bnoordhuis & @srl295. Gone through the resources you shared, and I think I understand what to do.

Great

This is my first time contributing here and I'm not sure what the contributing guideline is. Would appreciate any pointers. Thanks.

Start here https://github.com/nodejs/node/blob/main/CONTRIBUTING.md

[richardlau]

ICU has a whole guide on this topic, https://unicode-org.github.io/icu/userguide/datetime/timezone/#updating-the-time-zone-data And I thought node has a guide as well?

Yes, https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data

[srl295]

I’d start with manually following the nodejs update instructions

…

Sent from my iPad

On Jul 8, 2022, at 7:14 PM, Richard Lau ***@***.***> wrote:  ICU has a whole guide on this topic, https://unicode-org.github.io/icu/userguide/datetime/timezone/#updating-the-time-zone-data And I thought node has a guide as well? Yes, https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

[rapaktech]

I'll get started. Thanks @richardlau & @srl295!