Deprecates --max-scale/--min-scale for more consistent naming

[mpetason]

Description

This PR updates --max-scale and --min-scale to --scale-max and --scale-min

Changes

• Updated --max-scale to --scale-max
• Updated --min-scale to --scale-min

Reference

#822

[mpetason]

This may require additional work. I wasn't sure if I should be changing some of the function names and others to match the renaming.

[daisy-ycguo]

I'm fine with the changes. Thank you. I don't think we need to change functions or variable names to match the option name change, because the annotation keys defined in the serving side are still using minScale and maxScale.

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/service/configuration_edit_flags.go	85.1%	85.4%	0.3

[mpetason]

I think this is ready for another review. Do I need to resolve previous conversations before that happens?

[maximilien]

/lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daisy-ycguo, maximilien, mpetason

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [maximilien]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cardil]

This PR contradicts the whole movement of knative/serving#12103 to align the option names, by using names in inverted form to what is currently supported.