Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Document that non-fixture contexts/pages should be closed when no longer needed #14252

Open
alexeyr-c opened this issue May 18, 2022 · 1 comment
Labels
good first issue

Comments

@alexeyr-c
Copy link

@alexeyr-c alexeyr-c commented May 18, 2022

When a BrowserContext is not obtained from a Playwright Test fixture, but from browser.newContext() in a test or when using Playwright Library, it should be closed once no longer needed (according to @mxschmitt at https://stackoverflow.com/questions/72284057/do-playwright-browser-contexts-opened-manually-need-to-be-closed?noredirect=1#comment127709001_72284057). Similarly pages from context/browser.newPage() should be closed if they are no longer needed and the context is long-living.

However, I wasn't able to find any place in documentation and examples saying this; the only hint was the existence of close methods. Please consider documenting it.

@rwoll rwoll added the good first issue label May 18, 2022
@umaraj79
Copy link

@umaraj79 umaraj79 commented May 22, 2022

I am new to it! Where do you have the documentations! I can write the documentation for context/browser.newPage()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue
Projects
None yet
Development

No branches or pull requests

3 participants