Conversation
| raise NotImplementedError("to_swagger") | ||
|
|
||
| def with_scopes(self, scopes): | ||
| def with_scopes(self, scopes: List[str]) -> 'Authorizer': |
There was a problem hiding this comment.
Since from __future__ import annotations is only supported for python 3.7+
To support v3.6, We are using quotes for annotations referring to classes declared after usage. Example - 'Authorizer'
| # A backoff factor to apply between attempts after the second try. | ||
| backoff_factor=2, | ||
| method_whitelist=['GET', 'POST', 'PUT'], | ||
| allowed_methods=['GET', 'POST', 'PUT'], |
There was a problem hiding this comment.
Fixes method_whitelist deprecation warning in the next version from urllib3 library
There was a problem hiding this comment.
Would you mind sending a separate PR for this? I'd like to keep this one just focused on removing the app.pyi file.
|
Thanks for starting the work on this! I reran the failed jobs (looks like there's an unrelated intermittent test failure I need to track down). Looks like there's some type errors that are now failing. |
@jamesls Thanks for taking a look! Yes, I did shift all the type declarations to |
|
Wow, thanks for doing this! Taking a look now. |
jamesls
left a comment
jamesls
left a comment
There was a problem hiding this comment.
Looks good to me. I'm going to go ahead and squash/merge. I'll also spend some time seeing if we can get even more specific with some of these types and replace some of these Anys.
PR #1932 * adityamohta/master: Add type definitions to app.py
Excellent, Thanks for taking out time @jamesls !
Awesome! |
2 participants
Issue #1802
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.