Skip to content

chore: retry refactor#302

Merged
scarmuega merged 3 commits intomainfrom
rvcas/retry_refactor
Jun 16, 2022
Merged

chore: retry refactor#302
scarmuega merged 3 commits intomainfrom
rvcas/retry_refactor

Conversation

@rvcas
Copy link
Copy Markdown
Member

@rvcas rvcas commented May 17, 2022

  • as discussed on discord this refactors the sinks gcp_pubsub and webhook to use the retry_operation util.

@rvcas rvcas requested a review from scarmuega as a code owner May 17, 2022 18:43
scarmuega
scarmuega previously approved these changes May 17, 2022
@scarmuega
Copy link
Copy Markdown
Member

awesome!!

@rvcas rvcas force-pushed the rvcas/retry_refactor branch from bdf862a to 6fad310 Compare May 20, 2022 22:03
@rvcas rvcas force-pushed the rvcas/retry_refactor branch from 6fad310 to c87f4b6 Compare May 30, 2022 22:34
feat(sink/gcp_pubsub): use utils retry_operation

fix: remove async_recursion

feat: make retry_policy part of the configs

fix: max_backoff to 20x

feat: deserialize duration from milliseconds as a u64 in toml

feat: start gcp cloud functions

feat: add docs for cloud function and the retry policy

chore: update cargo toml feaure flags

chore: more docs
@rvcas rvcas force-pushed the rvcas/retry_refactor branch from 14f20d6 to 7bd2274 Compare May 31, 2022 00:15
scarmuega
scarmuega previously approved these changes Jun 2, 2022
@scarmuega
Copy link
Copy Markdown
Member

amazing!

@scarmuega scarmuega merged commit dbf2798 into main Jun 16, 2022
@scarmuega scarmuega deleted the rvcas/retry_refactor branch June 16, 2022 00:46
kodemill pushed a commit to kodemill/oura that referenced this pull request Jun 24, 2022
Co-authored-by: Santiago Carmuega <santiago@carmuega.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants