Redis stream sink (simplified version)#308
Closed
kieransimkin wants to merge 2 commits intotxpipe:mainfrom
Closed
Conversation
kieransimkin
changed the title
rvcas
approved these changes
May 29, 2022
| pub paritioning: Option<PartitionStrategy>, | ||
| } | ||
|
|
||
| pub fn redis_connection(u: String) -> Connection { |
Member
|
awesome! |
Member
|
hi @kieransimkin! Thank you for this great PR. Sadly, as you already know, we had an ongoing effort from @Sbcdn to implement the Redis sink feature. It was put on-hold waiting for some design decision, but it has now been merged. It would be much appreciated if you could review the already merged code and see if makes sense from the perspective of your use-case. If you find anything missing from the current implementation, we could maybe adapt your PR as an adjustment on top. Let me know what you think. Thanks again for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added simplified Redis stream support (based on @Sbcdn work), this is tested and working in use at Artifct