Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hamburger menu mode configurable via config option #3869

Open
asaini opened this issue Oct 1, 2021 · 6 comments
Open

Make hamburger menu mode configurable via config option #3869

asaini opened this issue Oct 1, 2021 · 6 comments
Labels
enhancement good first issue

Comments

@asaini
Copy link

@asaini asaini commented Oct 1, 2021

Problem

See #3856 . Developer would like the ability to configure whether the developer menu or viewer menu is displayed while they are developing on cloud IDEs like Gitpod or Github Codespaces

Solution

Create a config option

showDeveloperMenu: true | false | auto

where

  • true: always shows the developer menu locally and while deployed
  • false: always shows the viewer menu locally and while deployed
  • auto: shows developer menu when on localhost and viewer menu when on non-localhost deployment (This is the current behavior on Streamlit Cloud)

default is set to auto

@ilias-ant
Copy link

@ilias-ant ilias-ant commented Oct 3, 2021

hello! can i work on this issue?

@vdonato
Copy link
Member

@vdonato vdonato commented Oct 7, 2021

Hi @ilias-ant, feel free to give this issue a try!

@pratimugale
Copy link

@pratimugale pratimugale commented Jan 10, 2022

Hi @vdonato , I do not see any PR mentioning this issue. Can I pick this up?

@ilias-ant
Copy link

@ilias-ant ilias-ant commented Jan 10, 2022

Hi @pratimugale - unfortunately, I didn't have time to work on this, so you can definitely pick this up :) (i was the original request-ee)

@vdonato
Copy link
Member

@vdonato vdonato commented Jan 11, 2022

Hi @pratimugale, I'd recommend not working on this one at the moment. There's currently a good amount of internal discussion regarding tweaks we want to make to the hamburger menu, and because of this I'd prefer to hold off on changes to this part of the codebase until we're sure what we want to do with it.

@pratimugale
Copy link

@pratimugale pratimugale commented Jan 11, 2022

Okay sure 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue
Projects
None yet
Development

No branches or pull requests

4 participants