Skip to content

fix: observers not being cleared on despawning NetworkObject #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
0xFA11 merged 5 commits into from
Jun 10, 2022
Merged

fix: observers not being cleared on despawning NetworkObject #2009

0xFA11 merged 5 commits into from
Jun 10, 2022

Conversation

@NoelStephensUnity
Copy link
Member

@NoelStephensUnity NoelStephensUnity commented Jun 10, 2022 •
edited
Loading

NetworkObjects were not getting their observers list cleared upon being despawned.
This PR resolves this issue.

MTT-3476
MTT-3134
Also pertaining to Github Issue #2007

Changelog

  • Fixed: issue where NetworkObject.Observers was not being cleared when despawned

Testing and Documentation

  • Includes integration test.

@NoelStephensUnity
fix
a35b64e 
This resolves the issue where when a NetworkObject is despawned but not destroyed the observers list was not being cleared.
@NoelStephensUnity
Update CHANGELOG.md
76cf86d 
MTT-3476
MTT-3134
@NoelStephensUnity
test
4989b4c 
this validates the fix for
MTT-3476
MTT-3134
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner June 10, 2022 18:08
@0xFA11 0xFA11 merged commit 352db12 into develop Jun 10, 2022
@0xFA11 0xFA11 deleted the fix/observers-not-being-cleared-on-despawn branch June 10, 2022 19:06
@ashwinimurt ashwinimurt mentioned this pull request Jun 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@0xFA11 0xFA11 0xFA11 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NoelStephensUnity @0xFA11