Rename scheduleID to scheduledEventID and startedID to startedEventID#2992
Merged
alexshtin merged 3 commits intotemporalio:masterfrom Jun 15, 2022
Merged
Conversation
alexshtin
force-pushed
the
feature/rename-schedule-id
branch
from
2fef7ac to
6b5d9b3
Compare
Contributor
|
I assume this contains only rename changes. |
yux0
approved these changes
Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Rename
scheduleIDtoscheduledEventIDandstartedIDtostartedEventID. And fix all corresponding names.Why?
To give fields a better name.
How did you test it?
Existing tests.
Potential risks
No risks. SQL column names are left as is.
Is hotfix candidate?
No.
Note for reviewers
Please review
protofiles only. All the rest is just mechanical renames and consequences for consistency.