Closed
Conversation
I want to specify where filed are being downloaded. Defaulting to Capybara.save_path is probably an okay default but then the downloads and screenshots are mixed. With this change you can pass save_path to driver initiation. Capybara::Cuprite::Driver.new(app, save_path: "tmp/capybara/downloads") An alternative would be to manually send the command to move download path. driver.browser.page.command( "Page.setDownloadBehavior", behavior: "allow", downloadPath: "tmp/capybara/simons" )
Author
|
Whoops, seams like a duplicate of #192 |
Contributor
|
Just FYI I've bumped #192 to https://github.com/rubycdp/cuprite/pull/217/files 🙇 |
Member
|
I'll merge #192 thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to specify where filed are being downloaded. Defaulting to
Capybara.save_path is probably an okay default but then the downloads
and screenshots are mixed.
With this change you can pass save_path to driver initiation.
An alternative would be to manually send the command to move
download path.
related to #181
We use it for spec and have a helper module which looks like this. Would you like to include it in cuprite? I think not since you probably want downloads for this tab/page not all downloads