Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add DEPENDENCIES.md #4710

Merged
merged 1 commit into from Apr 13, 2022
Merged

chore: add DEPENDENCIES.md #4710

merged 1 commit into from Apr 13, 2022

Conversation

wraithgar
Copy link
Contributor

@wraithgar wraithgar commented Apr 8, 2022

This adds a script to generate dependency information for the npm cli.
The dependency info shows all of the packages in npm that the npm-cli
team themselves manage.

This will help us especially when introducing semver-breaking changes (such as updating the engines) in our repos.

@wraithgar wraithgar requested a review from as a code owner Apr 8, 2022
@wraithgar
Copy link
Contributor Author

@wraithgar wraithgar commented Apr 8, 2022

npm's devDependencies are in this chain, but of course none of its dependencies devDependencies are. I am not sure if we should keep those in here, breaking changes in devDependencies (outside of template-oss) don't usually mean a breaking change to the dependent.

@npm-robot
Copy link
Contributor

@npm-robot npm-robot commented Apr 8, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 53.926 ±1.85 28.311 ±0.08 29.050 ±17.55 18.719 ±0.86 2.807 ±0.16 2.743 ±0.12 2.124 ±0.03 10.548 ±0.19 2.127 ±0.02 3.134 ±0.09
#4710 49.332 ±4.28 29.261 ±0.36 16.782 ±0.16 19.103 ±1.16 2.866 ±0.03 2.752 ±0.09 2.269 ±0.02 10.921 ±0.55 2.141 ±0.01 3.284 ±0.01
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 37.489 ±1.37 21.907 ±0.09 12.104 ±0.10 12.816 ±0.55 2.430 ±0.05 2.523 ±0.06 2.282 ±0.06 7.732 ±0.38 2.285 ±0.32 2.735 ±0.04
#4710 35.860 ±1.17 22.308 ±0.29 12.180 ±0.24 13.083 ±0.06 2.499 ±0.13 2.608 ±0.05 2.285 ±0.01 7.913 ±0.11 2.092 ±0.00 2.859 ±0.06

@wraithgar wraithgar marked this pull request as draft Apr 11, 2022
This adds a script to generate dependency information for the npm cli.
The dependency info shows all of the packages in npm that the npm-cli
team themselves manage.
@wraithgar wraithgar marked this pull request as ready for review Apr 11, 2022
fritzy
fritzy approved these changes Apr 13, 2022
@fritzy fritzy merged commit 877138e into latest Apr 13, 2022
31 checks passed
@fritzy fritzy deleted the gar/dependency-graph branch Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants